Re: Towards a cleaner build

[Lars Ingebrigtsen]

I had a gander.  :-)

It doesn't really look that complicated.  So we'd introduce a new
function with-suppressed-warnings along the lines of with-no-warnings:

(byte-defop-compiler-1 with-no-warnings byte-compile-no-warnings)
(defun byte-compile-no-warnings (form)
  (let (byte-compile-warnings)
    (byte-compile-form (cons 'progn (cdr form)))))

And the warnings are issued in contexts like this:

(defun byte-compile-warn-obsolete (symbol)
  "Warn that SYMBOL (a variable or function) is obsolete."
  (when (byte-compile-warning-enabled-p 'obsolete)
    ...))

So that would change to

   (byte-compile-warning-enabled-p 'obsolete symbol)

and the main logic for seeing whether we want to warn for that obsolete
symbol (etc) would basically be all constrained to the
`byte-compile-warning-enabled-p' function?

So if we want to go this direction it looks like it can be done in a
pretty clean fashion.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no