Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check

[Robert Pluim]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
>> Date: Mon, 11 Jan 2021 18:53:51 +0100
>> 
>> (require 'dns)
>> (skip-unless (dns-query "google.com" 'AAAA))
>> 
>> and then do the network-lookup-address-info tests (although on Windows
>> this depends on DNS over TCP working, and either /etc/resolv.conf or a
>> working nslookup). Eli?
>
> Tell me what to try, and I will show the results.  TIA.

Iʼve lost track of which tests were failing, but something like
following. And if the 'dns-query' calls succeed but the
network-lookup-address-info ones fail then we have a really messed up
situation.

diff --git a/test/src/process-tests.el b/test/src/process-tests.el
index 921bcd5f85..172294b0ed 100644
--- a/test/src/process-tests.el
+++ b/test/src/process-tests.el
@@ -356,7 +356,9 @@ lookup-family-specification
   (with-timeout (60 (ert-fail "Test timed out"))
   (should-error (network-lookup-address-info "google.com" 'both))
   (should (network-lookup-address-info "google.com" 'ipv4))
-  (when (featurep 'make-network-process '(:family ipv6))
+  (when (and (featurep 'make-network-process '(:family ipv6))
+             (require 'dns)
+             (dns-query "google.com" 'AAAA))
     (should (network-lookup-address-info "google.com" 'ipv6)))))
 
 (ert-deftest lookup-unicode-domains ()
@@ -380,7 +382,9 @@ lookup-google
         (addresses-v4 (network-lookup-address-info "google.com" 'ipv4)))
     (should addresses-both)
     (should addresses-v4))
-  (when (featurep 'make-network-process '(:family ipv6))
+  (when (and (featurep 'make-network-process '(:family ipv6))
+             (require 'dns)
+             (dns-query "google.com" 'AAAA))
     (should (network-lookup-address-info "google.com" 'ipv6)))))
 
 (ert-deftest non-existent-lookup-failure ()