Re: Proposing changes to adjust_frame_size

[martin rudalics]

> 11:15 <tsdh> Does it support resize requests?  What happens when you make an
>               already visible frame invisible or iconified?  Does it support
>               size hints?
> 11:15 <tsdh> "it" is sway, and frame = WM window.
> 11:16 <emersion> resize requests: yes

Funny.  I would say that

if (!container_is_floating(view->container)) {
                return;
        }

from the URL below should say "no" but maybe I'm missing something.  Can
you change the size of a frame by setting its 'width' or 'height'
parameter?  Does your frame resize when you toggle the vertical scroll
bar on/off?

> 11:16 <emersion> size hints: yes

We'll look into that, eventually.

> 11:16 <emersion> iconified: iirc that does nothing
> 11:16 <emersion> but not sure
> 11:16 <emersion> all of this assumes an x11 client
> 11:17 <tsdh> emersion: Yes, right now, emacs is an x11 client (GTK3 built).
> 11:18 <tsdh> What does sway when a new emacs frame should be mapped and
>               requests a certain size?  It's at least not honored in tiling
>               mode which is obviously fine.
> 11:25 <emersion> 
https://github.com/swaywm/sway/blob/31b4b96ebf2af88630752d8518fd360ff84cf3e5/sway/desktop/xwayland.c#L584
> 11:28 <tsdh> Thanks!
> --8<---------------cut here---------------end--------------->8---
>
>> ... and this is our usual annoyance.  I attached a new patch which
>> should handle these cases as well.  If there's anything else left,
>> please tell me.
>
> The new version handles all cases we've had so far.  Thanks!

I've pushed it now.  It should fail in the usual manner with

(setq frame (make-frame '((visibility . nil) (width . 80))))
(make-frame-visible frame)

Please verify.

And many thanks for testing, martin