[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs is not reproducible
From: |
Stefan Monnier |
Subject: |
Re: Emacs is not reproducible |
Date: |
Mon, 17 May 2021 12:40:39 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> Is there currently any work underway to make Emacs reproducible?
There has been changes made in the past to fix some problems.
I have a pending patch in bug#46502 (see below) which aims to fix some
more of those problems, but still haven't heard confirmation that it
helps.
Stefan
diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el
index e0feb95a46..06c925b7bf 100644
--- a/lisp/emacs-lisp/byte-opt.el
+++ b/lisp/emacs-lisp/byte-opt.el
@@ -268,32 +269,16 @@ byte-compile-inline-expand
;; The byte-code will be really inlined in byte-compile-unfold-bcf.
`(,fn ,@(cdr form)))
((or `(lambda . ,_) `(closure . ,_))
- (if (not (or (eq fn localfn) ;From the same file => same mode.
- (eq (car fn) ;Same mode.
- (if lexical-binding 'closure 'lambda))))
- ;; While byte-compile-unfold-bcf can inline dynbind byte-code into
- ;; letbind byte-code (or any other combination for that matter), we
- ;; can only inline dynbind source into dynbind source or letbind
- ;; source into letbind source.
- (progn
- ;; We can of course byte-compile the inlined function
- ;; first, and then inline its byte-code.
- (byte-compile name)
- `(,(symbol-function name) ,@(cdr form)))
- (let ((newfn (if (eq fn localfn)
- ;; If `fn' is from the same file, it has already
- ;; been preprocessed!
- `(function ,fn)
- ;; Try and process it "in its original environment".
- (let ((byte-compile-bound-variables nil))
- (byte-compile-preprocess
- (byte-compile--reify-function fn))))))
- (if (eq (car-safe newfn) 'function)
- (macroexp--unfold-lambda `(,(cadr newfn) ,@(cdr form)))
- ;; This can happen because of macroexp-warn-and-return &co.
- (byte-compile-warn
- "Inlining closure %S failed" name)
- form))))
+ (if (eq fn localfn) ;From the same file => same mode.
+ (macroexp--unfold-lambda `(,fn ,@(cdr form)))
+ ;; While byte-compile-unfold-bcf can inline dynbind byte-code into
+ ;; letbind byte-code (or any other combination for that matter), we
+ ;; can only inline dynbind source into dynbind source or letbind
+ ;; source into letbind source.
+ ;; We can of course byte-compile the inlined function
+ ;; first, and then inline its byte-code.
+ (byte-compile name)
+ `(,(symbol-function name) ,@(cdr form))))
(_ ;; Give up on inlining.
form))))
- Emacs is not reproducible, Bone Baboon, 2021/05/17
- Re: Emacs is not reproducible, Alan Mackenzie, 2021/05/17
- Re: Emacs is not reproducible, Eli Zaretskii, 2021/05/17
- Re: Emacs is not reproducible,
Stefan Monnier <=
- Re: Emacs is not reproducible, Stefan Monnier, 2021/05/22
- Re: Emacs is not reproducible, Glenn Morris, 2021/05/23
- Re: Emacs is not reproducible, Stefan Monnier, 2021/05/25
- Re: Emacs is not reproducible, T.V Raman, 2021/05/25
- Re: Emacs is not reproducible, Glenn Morris, 2021/05/25
- Re: Emacs is not reproducible, Stefan Monnier, 2021/05/26
- Re: Emacs is not reproducible, Mattias EngdegÄrd, 2021/05/27
- Re: Emacs is not reproducible, Stefan Monnier, 2021/05/27
- Re: Emacs is not reproducible, Basil L. Contovounesios, 2021/05/25
- Re: Emacs is not reproducible, Stefan Monnier, 2021/05/27