[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Moving point after character when clicking latter half of it
From: |
Eli Zaretskii |
Subject: |
Re: Moving point after character when clicking latter half of it |
Date: |
Tue, 11 Jul 2023 15:29:57 +0300 |
> From: Moritz Maxeiner <mm@ucw.sh>
> Cc: emacs-devel@gnu.org
> Date: Mon, 10 Jul 2023 22:02:23 +0200
>
> On Monday 10 July 2023 14:46:39 CEST Eli Zaretskii wrote:
> > It should also be called out in etc/NEWS.
>
> I agree, but I feel this should be done in the last iteration of the patch,
> once all other changes are done.
We are basically there.
> I had to add another piece of code to src/xterm.c, because while text
> selection via mouse dragging did automatically factor in the new optional
> behavior after releasing the mouse, it did not update the highlighted /
> selected region, as that requires mouse-movement events to be triggered,
> which
> are picked up in mouse.el via mouse-drag-track, which then updated the
> highlighted region. That event, however, is only triggered by leaving the
> previous glyph, so we need to trigger it while still being on the glyph.
>
> I tried sending the event only when crossing the vertical midline of the
> glyph, but for a reason unknown to me, sending the event only once did not
> result in the highlight being updated when dragging the mouse to the right,
> only to the left.
>
> As a workaround, I now trigger the event always while dragging with the
> optional behavior on. If there is a more elegant solution I don't see I'd
> welcome it. For now the overhead doesn't seem noticeable in practice.
I'm not sure this is TRT. In particular, it sounds like the change
you made in xterm.c also overrides the Y coordinate condition? that
doesn't sound right to me. Po Lu, WDYT about this?
The other changes LGTM, thanks.
- Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/09
- Re: Moving point after character when clicking latter half of it, Eli Zaretskii, 2023/07/09
- Re: Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/09
- Re: Moving point after character when clicking latter half of it, Eli Zaretskii, 2023/07/09
- Re: Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/09
- Re: Moving point after character when clicking latter half of it, Eli Zaretskii, 2023/07/09
- Re: Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/09
- Re: Moving point after character when clicking latter half of it, Eli Zaretskii, 2023/07/10
- RE: [External] : Re: Moving point after character when clicking latter half of it, Drew Adams, 2023/07/10
- Re: Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/10
- Re: Moving point after character when clicking latter half of it,
Eli Zaretskii <=
- Re: Moving point after character when clicking latter half of it, Po Lu, 2023/07/11
- Re: Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/11
- Re: Moving point after character when clicking latter half of it, Po Lu, 2023/07/11
- Re: Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/12
- Re: Moving point after character when clicking latter half of it, Yuan Fu, 2023/07/12
- Re: Moving point after character when clicking latter half of it, Moritz Maxeiner, 2023/07/12
- Re: Moving point after character when clicking latter half of it, Yuan Fu, 2023/07/12
- Re: Moving point after character when clicking latter half of it, Eli Zaretskii, 2023/07/13
- Re: Moving point after character when clicking latter half of it, Yuan Fu, 2023/07/13
- Re: Moving point after character when clicking latter half of it, Po Lu, 2023/07/12