emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 645f1b2cd4 25/25: transient--stack-push: Pres


From: Jonas Bernoulli
Subject: [elpa] externals/transient 645f1b2cd4 25/25: transient--stack-push: Preserve the value
Date: Tue, 3 Dec 2024 14:35:03 -0500 (EST)

branch: externals/transient
commit 645f1b2cd4881a7fb7acb2d2a3bc125701786e05
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    transient--stack-push: Preserve the value
    
    Since [1: 179545a6] we re-initialize suffixes when returning to the
    outer prefix, that also resulted in the value of the prefix and the
    values of the suffixes being re-initialized.
    
    We can prevent that by storing the value on the prefix stack, as we
    are already doing for the scope.
    
    The value of a prefix's `value' slot is not updated when the user
    changes the value of a suffix, so we cannot use the current value
    of that.  Instead we have to collect the up-to-date value from the
    suffixes.
    
    Closes #333.
    
    1: 2024-11-13 179545a6e29899aa89cbd77962a1c882f45927ca
       Re-initialize suffixes when returning to :refresh-suffixes prefix
---
 lisp/transient.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index 4949db7f3a..e14cbf2d40 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -2714,7 +2714,8 @@ value.  Otherwise return CHILDREN as is."
               transient--layout
               transient--editp
               :transient-suffix (oref transient--prefix transient-suffix)
-              :scope (oref transient--prefix scope))
+              :scope (oref transient--prefix scope)
+              :value (transient-get-value))
         transient--stack))
 
 (defun transient--stack-pop ()



reply via email to

[Prev in Thread] Current Thread [Next in Thread]