[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient b3f3aa034a 09/25: transient-init-value: Defin
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient b3f3aa034a 09/25: transient-init-value: Define noop method for transient-suffix |
Date: |
Tue, 3 Dec 2024 14:35:01 -0500 (EST) |
branch: externals/transient
commit b3f3aa034a8fe48ef489eca9ad713ff606ff0827
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient-init-value: Define noop method for transient-suffix
Previously this was handled by the default method we used to create
with `cl-defgeneric'. If no method is defined for a third-party class
directly deriving from `transient-infix' this now results in a useful
error.
---
lisp/transient.el | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index 8a82587e14..f9bdc08b2d 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -3190,16 +3190,13 @@ such as when suggesting a new feature or reporting an
issue."
;;; Value
;;;; Init
-(cl-defgeneric transient-init-value (_)
+(cl-defgeneric transient-init-value (obj)
"Set the initial value of the object OBJ.
This function is called for all prefix and suffix commands.
-For suffix commands (including infix argument commands) the
-default implementation is a noop. Classes derived from the
-abstract `transient-infix' class must implement this function.
-Non-infix suffix commands usually don't have a value."
- nil)
+Third-party subclasses of `transient-infix' must implement a primary
+method.")
(cl-defmethod transient-init-value :around ((obj transient-prefix))
"If bound, then call OBJ's `init-value' function.
@@ -3223,6 +3220,10 @@ Otherwise call the primary method according to object's
class."
(cdr saved)
(transient-default-value obj)))))
+(cl-defmethod transient-init-value ((_ transient-suffix))
+ "Non-infix suffixes usually don't have a value, so this is a noop."
+ nil)
+
(cl-defmethod transient-init-value ((obj transient-argument))
(oset obj value
(let ((value (oref transient--prefix value))
- [elpa] externals/transient updated (35bbc35929 -> 645f1b2cd4), Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient c9a62d5a16 10/25: Improve doc-strings of functions dealing with values, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient deb1569c9c 07/25: transient-prefix-value: New generic function, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient c93c35f567 13/25: transient--show: Fix window height for more setups, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient aaefee0d01 03/25: Remove comments mentioning a legacy Emacs bug, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 3b28a2f8d6 12/25: transient-hide-during-minibuffer-read: Change default to t, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 3539231b98 20/25: fixup(e3e2e111): Improve options for showing menu during minibuffer use, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 645f1b2cd4 25/25: transient--stack-push: Preserve the value, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient d64b73efbc 17/25: transient-scope: Return nil if all prefixes are nil, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient ecdee415fb 16/25: transient-scope: Fully revert behavior with no argument, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient b3f3aa034a 09/25: transient-init-value: Define noop method for transient-suffix,
Jonas Bernoulli <=
- [elpa] externals/transient 4130f62966 11/25: transient--show: Run transient-setup-buffer-hook later, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 24a1be509b 02/25: docs: Fix word order, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient d0cba152dc 06/25: transient-scope: Add PREFIX argument, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 75f0aef8d7 04/25: Add new "Scope" top-level section, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 9259f77e14 05/25: transient-args: Allow PREFIX to be a list of prefixes, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 6b83a02151 08/25: transient-init-scope: Add stub method for prefixes, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 37be15575a 23/25: fixup(e3e2e111): Improve options for showing menu during minibuffer use, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 4de5812992 15/25: transient-scope: Fix recent regression, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient 51f25c21b8 24/25: Fix typos in documentation, Jonas Bernoulli, 2024/12/03
- [elpa] externals/transient cb5e1e5594 18/25: transient-scope: Redesign, Jonas Bernoulli, 2024/12/03