emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 3b28a2f8d6 12/25: transient-hide-during-minib


From: Jonas Bernoulli
Subject: [elpa] externals/transient 3b28a2f8d6 12/25: transient-hide-during-minibuffer-read: Change default to t
Date: Tue, 3 Dec 2024 14:35:02 -0500 (EST)

branch: externals/transient
commit 3b28a2f8d6672eb210ef7fa0392c2a9132ff53b0
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    transient-hide-during-minibuffer-read: Change default to t
    
    That way the menu is consistently hidden during all minibuffer usage
    by suffix commands, *including* when setting infix arguments.
    
    Beside the increased consistency, this is beneficial for large menus
    (such as `magit-log') in combination with completion setups that
    immediately show a set of completion candidates.  In such cases there
    could be very little space left to display anything beside the menu
    and the completion candidates.
    
    Additionally this helps to avoid an incompatibility when displaying the
    menu using the full frame height.  See the next commit for details on
    that.
---
 CHANGELOG         |  4 ++++
 lisp/transient.el | 11 ++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG b/CHANGELOG
index 8c74e30177..641cc4cb34 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -18,6 +18,10 @@
 - ~transient-setup-buffer-hook~ is now run later to allow overriding
   more default settings.
 
+- While the minibuffer is in use, the menu buffer is now hidden by
+  default.  Customize ~transient-hide-during-minibuffer-read~ if you
+  prefer the old default.
+
 Bug fixes:
 
 - Fixes some menu navigation edge-cases.
diff --git a/lisp/transient.el b/lisp/transient.el
index df4d7a9e70..e7ecb50e8c 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -385,9 +385,14 @@ text and might otherwise have to scroll in two dimensions."
   :group 'transient
   :type 'boolean)
 
-(defcustom transient-hide-during-minibuffer-read nil
-  "Whether to hide the transient buffer while reading in the minibuffer."
-  :package-version '(transient . "0.4.0")
+(defcustom transient-hide-during-minibuffer-read t
+  "Whether to hide the transient buffer while reading in the minibuffer.
+
+This is only relevant to commands that do not close the menu, such
+as commands that set infix arguments.  If a command exits the menu,
+and uses the minibuffer, then the menu is always closed before the
+minibuffer is entered, irrespective of the value of this option."
+  :package-version '(transient . "0.8.0")
   :group 'transient
   :type 'boolean)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]