Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> On 12/03/2024 20:03, Ihor Radchenko wrote:
>> Max Nikulin writes:
>>> It is trivial to cause shell failure when single quotes are used around
>>> %i. I am in doubts concerning double quotes. Perhaps stripping them is
>>> more reliable.
>> 
>> May you list the cases to you propose to recognize?
>
> Sun, 25 Feb 2024 17:41:43 +0700
> https://list.orgmode.org/6e49c590-ad27-4fb0-b1f2-6a89c60a0b58@gmail.com
>
> - '%i' and "%i" in any position including e.g. --option='%i' and 
> protocol:"%i"
> - 'something%i' and "something%i" surrounded by spaces or at the end of 
> command but with no spaces in "something".

I am not confident that it will be safe. For example, consider something
awkward like foo\"%ibar\". I imagine that other edge cases are possible,
especially in exotic shells.

> ...  It should be applied to %%%i, 
> but not to %%i.

I am not sure what you mean here.

>>> - I expected it as bugfix.
>> 
>> It is a breaking change.
>> Also, only users who customized the variable may be prone to unexpected
>> shell expansion. So, I do not see it as a critical bug.
>> Hence, not for bugfix.
>
> I am still in doubts. I have no idea how much users need ODT export with 
> math and rely on the backend shipped with Org. All of them have to 
> customize the user option and those who added %i with quotes have risk 
> to get incorrect output. If quotes around %i are stripped then the 
> change is not breaking one for most of them.

It does not matter that most users will not be affected. Some users
being affected is enough to not commit this to bugfix. Our policy is not
to commit unsafe changes that may break existing configurations to
bugfix branch. Except critical fixes. See
https://orgmode.org/worg/org-maintenance.html#release-types

>>> Moreover, it
>>> does not work in a container where git is not installed:
>>> ...
>>> Debugger entered--Lisp error: (file-missing "Searching for program" "No
>>> such file or directory" "git")
>> 
>> with emacs -Q?
>
> emacs -Q --batch --eval '(find-file-noselect "not-found.txt" t)'
> Starting new Ispell process ispell with default dictionary... \
> Error enabling Flyspell mode:
> (Searching for program No such file or directory ispell)
> Error: (file-missing "Searching for program" "No such file or directory" 
> "git")
>
> Emacs-28.2
>
> ispell error is due to my .dir-locals-2.el
>   (text-mode . ((mode . flyspell)))
> bug to get the git error it is enough to create .git subdirectory.

This looks like Emacs bug. Likely in `vc-refresh-state'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>