Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command

[Max Nikulin]

On 15/03/2024 20:49, Ihor Radchenko wrote:
> Max Nikulin writes:
> > On 12/03/2024 20:03, Ihor Radchenko wrote:
> > - '%i' and "%i" in any position including e.g. --option='%i' and
> > protocol:"%i"
> > - 'something%i' and "something%i" surrounded by spaces or at the end of
> > command but with no spaces in "something".
>
> I am not confident that it will be safe. For example, consider something
> awkward like foo\"%ibar\". I imagine that other edge cases are possible,
> especially in exotic shells.

I think quotes should not be stripped in such peculiar cases. The 
variants I suggested do not match it. Is it realistic?

> > ...  It should be applied to %%%i,
> > but not to %%i.
>
> I am not sure what you mean here.

"%%" is a way to specify literal "%" in `format-spec'. So '%%i' means in 
%i shell command and unquoting should not be applied to it.

> > > > - I expected it as bugfix.
>
> It does not matter that most users will not be affected. Some users
> being affected is enough to not commit this to bugfix. Our policy is not
> to commit unsafe changes that may break existing configurations to
> bugfix branch. Except critical fixes.

Reasons why I consider this issue a severe enough:
- Something weird may be executed as shell commands
- Incorrect formulas in exported documents are more than just 
disappointment. An example of complain related to another bug:
Re: Inequalities in math blocks. Wed, 06 Oct 2021 09:39:23 +0200. 
https://list.orgmode.org/m2bl42bo0k.fsf@me.com

From my point of view, it is better to explain users that they are 
disturbed to be on the safe side. It is not choice between good and bad 
variants. Any decision is bad.

> > emacs -Q --batch --eval '(find-file-noselect "not-found.txt" t)'
> > Error: (file-missing "Searching for program" "No such file or directory"
> > "git")
>
> This looks like Emacs bug. Likely in `vc-refresh-state'.

It as an Emacs bug that missing git executable leads to a fatal error.

It is a bug in Org that some hooks are called when just file content is 
necessary.