Re: [freesci-develop] cleanup patch

[Lars Skovlund]

On Tue, Jan 27, 2009 at 12:09:24PM +0100, Jordi Vilalta wrote:
> Hi,
> 
> 2009/1/26 Max Horn <address@hidden>:
> > I saw no attachment to that mail. Seems there are problems with this list &
> > attachments. Maybe you guys should just upload patches somewhere, and then
> > send around mails with URLs to the patches? Right now I read in the #freesci
> > logs that you already noticed the missing patch, and that essentially things
> > are now delayed because Jordi tries to resend the patch... Let's try not to
> > get bad communication lines in the way of things :-). Like, Jordi could
> > email the patch directly to walter if walter wants to review it, instead of
> > trying to resend to this list and it then failing again... ;-)
> 
> Thanks for the advice :P Here's the patch I tried to send on my last mail:
> http://www-plan.cs.colorado.edu/freesci/tmp/headers_cleanup.patch

I've had a look at that patch now. There's only a couple of things:

* gfx_state.h is a part of the widget system, not the driver
  layer. As I wrote on the roadmap, we should keep the widget system
  around in the interest of SCI32 support. Even if we choose to get
  rid of the widget system eventually, it is premature to do so now
  (at least keep the patches separate).

* The same thing goes for gfx_sci.h

Other than that, I can't see any problems with it.

Regards,

Lars