Re: [Gnash-dev] Re: Bitwise stream reading performance

[strk]

On Mon, Aug 27, 2007 at 02:54:42PM +0200, strk wrote:
> On Mon, Aug 27, 2007 at 02:44:48PM +0200, Udo Giacomozzi wrote:
> > Hello strk,
> > 
> > Monday, August 27, 2007, 2:15:42 PM, you wrote:
> > s> gnash::stream exposes a get_underlying_stream, which is currently used
> > s> by some tag readers (embedded bitmaps usually). If we can remove any
> > s> use of the underlying file, cache can be enabled at the gnash::stream 
> > level,
> > s> otherwise we're stuck in doing it in the tu_file directly.
> > 
> > Why do they need access to the underlying stream? Odd.
> 
> Probably a left-over. Should be easy to fix.

It turns out it's not straightforward to fix.
Basically, it's some services of libgnashbase needing a tu_file,
and we're calling them from libgnashserver (which includes gnash::stream).

The services are:
 
  - jpeg::input::create_swf_jpeg2_header_only(tu_file*)
  - image::read_jpeg(tu_file*);
  - image::read_swf_jpeg3(tu_file*);

Changing the services to use a gnash::stream would require moving
out of libgnashbase and in libgnashserver, to avoid circular deps.
Alternatively, we might use a tu_file wrapper usign gnash::stream
internally (sounds like unneeded complexity).

--strk;