Re: [PATCH 2/5] gnu: Add seabios.

[Marius Bakke]

David Craven <address@hidden> writes:

> * gnu/packages/grub.scm (seabios): New variable.

I would place this in "firmware.scm".

> ---
>  gnu/packages/grub.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/grub.scm b/gnu/packages/grub.scm
> index 292d35373..a775e213c 100644
> --- a/gnu/packages/grub.scm
> +++ b/gnu/packages/grub.scm
> @@ -33,6 +33,7 @@
>    #:use-module (gnu packages gettext)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages linux)
> +  #:use-module (gnu packages python)
>    #:use-module (gnu packages qemu)
>    #:use-module (gnu packages man)
>    #:use-module (gnu packages texinfo)
> @@ -150,3 +151,40 @@ menu to select one of the installed operating systems.")
>                        (string-append (assoc-ref inputs "efibootmgr")
>                                       "/sbin/efibootmgr")))
>                     #t)))))))))
> +
> +(define-public seabios
> +  (package
> +    (name "seabios")
> +    (version "1.10.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "https://code.coreboot.org/p/seabios/downloads/get/";
> +                                  "seabios-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1jyjl719drnl1v0gf0l5q6qjjmkyqcqkka6s28dfdi0yqsxdsqsh"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("python-2" ,python-2)))
> +    (arguments
> +     `(#:tests? #f ; No check target.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((gcc (assoc-ref inputs "gcc")))
> +               (setenv "CC" (string-append gcc "/bin/gcc")))

Does it need the full path, or would simply "gcc" be enough here?

> +             #t))
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (fmw (string-append out "/share/firmware")))
> +               (mkdir-p fmw)
> +               (copy-file "out/bios.bin" (string-append fmw "/bios.bin"

                  #t))))))))

> +    (home-page "https://www.seabios.org/SeaBIOS";)
> +    (synopsis "x86 BIOS implementation")
> +    (description "SeaBIOS is an open source implementation of a 16bit x86 
> BIOS.
> +SeaBIOS can run in an emulator or it can run natively on X86 hardware with 
> the
> +use of coreboot.")
> +    ;; Dual licensed.
> +    (license (list license:gpl3+ license:lgpl3+))))

The Debian copyright file for this package mentions two other licenses
in use. They should probably be listed too. Otherwise LGTM.

Thank you!

> -- 
> 2.11.0

signature.asc
Description: PGP signature