Re: [PATCH 4/5] gnu: Add syslinux.

[David Craven]

> I think the most common convention is to use the latest upstream
> release, and adding revisions on top of it. But no strong opinion.

> I tried packaging 6.03 a while back and it was very difficult. Most if
> the problems seems to be solved here, so thanks for doing this.

In general I agree, but I found 6.03 to be hard to package. Maybe I could
try again now that something is building, but I expect that it would need
additional patches. And 6.03 is very old.

> This is unfortunate. The "unittest" target is applied recursively, and
> fails with "no such target" in one of the folders.
>
> However, I was able to successfully run the tests by calling the
> "unittest" target "manually" for some reason, like so:

Thank you! This works well.

> This software bundles some third-party code in the "com32" folder.
> address@hidden, zlib, and others. Their licenses should be mentioned
> here. Preferably they would be scrubbed from the source in favor of
> system versions, but that looks to be difficult.

Done.