guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] gnu: Add ovmf.


From: David Craven
Subject: Re: [PATCH 3/5] gnu: Add ovmf.
Date: Fri, 10 Feb 2017 14:18:44 +0100

> I would simply (replace 'build ...) here, instead of deleting it and
> using add-after.

I think it's a good idea to use small phases. This way it makes it
easier to extend or modify packages with
(package (inherit)). It also doesn't require an ugly (and build-this
build-that).

> Is it not possible to build this firmware on (not for) other archs?

That would require cross-compiling. Adding supported-systems doesn't
preclude someone from running
the build manually with --target=... but it avoids build failures in
cuirass/hydra.

> There appears to also be a good number of bsd-{2,3,4} licensed files in
> this distribution.

I'll add these then...

> I've tested both this and seabios with qemu, great work! :-)

Thanks :-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]