Re: ltdl.c ifdefs

[Gary V. Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bob Friesenhahn wrote:
| On 6 Apr 2004, Alexandre Oliva wrote:
|
|
|>On Apr  6, 2004, Bob Friesenhahn <address@hidden> wrote:
|>
|>
|>>#if WITH_DMALLOC
|>
|>>This form is clearly incorrect unless WITH_DMALLOC is always defined
|>>(e.g. as 1 or 0).
|>
|>Nope.  An undefined macro is equivalent to a macro defined to 0 in
|>preprocessor tests.  It's actually better to test with #if than #ifdef
|
|
| True, but it causes the Digital Unix compiler to issue warnings.
| Every compiler except for GCC issues great gobs of warnings when
| compiling ltdl.c and it would be nice to see the number of warnings
| reduced to zero.
|
| The oodles of warnings issued while compiling ltdl.c causes the
| package I maintain to appear of much lower quality than it actually
| is.

Maybe a new header for non gcc generated by configure (untested):

AC_CONFIG_COMMANDS([libltdl/lt__gcc.h],
[for lt_symbol in `$SED -e '/^#undef [A-Z_]*$/ {
~         s,^#undef \([A-Z_]*\)$,\1,;p;
~      }; d' $top_srcdir/config-h.in`
do
~  echo "#ifndef $lt_symbol"
~  echo "#  define $lt_symbol 0"
~  echo "#endif"
done > libltdl/lt__gcc.h
])

and then #include "lt__gcc.h" at the top of lt__private.h?

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAdDNdFRMICSmD1gYRAgFEAKC2UKbZfowxMAwaPGBAEag3KNv2AACfSBR+
axBvcDhYnKZzmM0ZuV5S4+Q=
=4sUF
-----END PGP SIGNATURE-----