Re: ltdl.c ifdefs

[Dalibor Topic]

Alexandre Oliva wrote:
> On Apr  7, 2004, "Gary V. Vaughan" <address@hidden> wrote:
>
>
> > Agreed.  Autoconf generates a config.h that encourages #ifdef/#ifndef.
>
>
> And then it promotes the use of #if.  I recall discussions about this
> in the autoconf list years ago, and there was a conscious decision to
> replace most uses of #ifdef with #if in the documentation, but I can't
> find any wording that explicitly recommends the use of #if over
> #ifdef.  Oh well...
>
>
> > We should just use that style throughout.
>
>
> And perhaps suggest that autoconf adds a note about this and reverts
> to ifdef to avoid such warnings.

I personally prefer

#if defined(SOMETHING)

since it can be simply extended if the need arises into

#if defined(SOMETHING) && !defined(SOMETHING_ELSE)

and gives no gcc style warnings, afaik :)

cheers,
dalibor topic