Re: ltdl.c ifdefs

[Gary V. Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Albert Chin wrote:
|>Maybe a new header for non gcc generated by configure (untested):
|>
|>AC_CONFIG_COMMANDS([libltdl/lt__gcc.h],
|>[for lt_symbol in `$SED -e '/^#undef [A-Z_]*$/ {
|>~         s,^#undef \([A-Z_]*\)$,\1,;p;
|>~      }; d' $top_srcdir/config-h.in`
|>do
|>~  echo "#ifndef $lt_symbol"
|>~  echo "#  define $lt_symbol 0"
|>~  echo "#endif"
|>done > libltdl/lt__gcc.h
|>])
|>
|>and then #include "lt__gcc.h" at the top of lt__private.h?
|
|
| What's the point? Is the gain of #if SYMBOL really worth it? libltdl
| is so small I say don't bother.

Agreed.  Autoconf generates a config.h that encourages #ifdef/#ifndef.

We should just use that style throughout.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAdEj6FRMICSmD1gYRAk7vAJ9NoQODYDDf5Of1vcGIUPgzY8abRQCgpek3
lMVIYl5DGX5HL5AsSlaHhyY=
=pUT5
-----END PGP SIGNATURE-----