Re: Report proper errors from the loadlibrary loader.

[Ralf Wildenhues]

Hi Peter,

* Peter Rosin wrote on Sat, Jan 02, 2010 at 04:02:57AM CET:
> Please consider the attached patch.
> 
> I'm just about to go skiing for a week or so, so I'll push when I get
> back if this patch is blessed (knock wood) after I leave...

Well happy new year and hope you had a fun time in the snow!

What does this patch and its followup fix get us?  What behavior changed
in relation to previous code, and if this is fixing a bug, is there need
and chance to test for it?

(honest questions, not trying to criticise the patch in any way)

Thanks,
Ralf

> ChangeLog:
> 
> 2010-01-02  Peter Rosin  <address@hidden>
> 
>       Report proper errors from the loadlibrary loader.
>       * libltdl/loaders/loadlibrary.c: Update copyright years.
>       (loadlibraryerror): New helper function that returns the
>       latest Windows error as a string, or the provided default
>       string on failure to do so.
>       (LOADLIB_SETERROR): New macro that wraps previous to make it
>       easy to use.
>       (vm_open, vm_close, vm_sym): Make use of previous.
>       (LOCALFREE): New macro to help free the Windows error string.
>       (vl_exit): Make use of previous.