Re: Report proper errors from the loadlibrary loader.

[Peter Rosin]

Den 2010-01-17 10:31 skrev Ralf Wildenhues:
> > > What does this patch and its followup fix get us?  What behavior changed
> > > in relation to previous code, and if this is fixing a bug, is there need
> > > and chance to test for it?
> > Previously the reported error was a plain "can't open the module" or
> > "symbol not found", even though the system might have reported why it
> > could not open the library or not find the symbol. I would say it's
> > about the same as using dlerror when present in the dlopen loader.
>
> Ah, ok.  Thanks.
>
> I'm not too fond of adding new static storage and manipulation (yet
> another reason lt_dlopen may not be called concurrently from different
> threads), or improved functionality without testsuite exposure that we
> really improved.  Further, the documentation I found about GetLastError
> states W2K as minimum version, so I hope that you checked that this
> works with older Windows as well.  Otherwise, I am fine with the patch.

Going back to what this actually brings us...

Previously we had reported errors of "can't open the module" and "symbol not
found". With the patch that turns into "The specified module could not be
found.\r\n" and "The specified procedure could not be found." (WinXP) or
"Module not found\r\n" and "Procedure not found\r\n" (Wine).

The \r\n at the end of the messages should probably be removed. And I did
manage to write a test that exposes this new functionallity - as you
requested - by unloading all modules except the loadlibrary loader (and
the preopen loader). The test is attached.

But, I have not succeeded in generating any other errors than the above
two. I have tried to remove execute bits on the plugin and a dependent
library, and I have tried removing a dependent library. But real problems
usually manifests themselves in weird ways and the correct error message
may be crucial in some unforseen case. Is it worth it?

Cheers,
Peter

--
They are in the crowd with the answer before the question.
> Why do you dislike Jeopardy?

loadlibrary.at
Description: Text document