Re: Report proper errors from the loadlibrary loader.

[Bob Friesenhahn]

On Sun, 17 Jan 2010, Ralf Wildenhues wrote:
> I'm not too fond of adding new static storage and manipulation (yet
> another reason lt_dlopen may not be called concurrently from different
> threads), or improved functionality without testsuite exposure that we
> really improved.  Further, the documentation I found about GetLastError
> states W2K as minimum version, so I hope that you checked that this
> works with older Windows as well.  Otherwise, I am fine with the patch.

It seems that GraphicsMagick has been using GetLastError() for a very 
long time.  Certainly at least since Y2K.  There is no special 
provision in this part of the code for anything older than Windows XP 
and Windows 2000.  Then again, practically no one cares about Windows 
versions older than this.

It is necessary to collect and store the error as soon as possible 
since any additional activity might invoke a new system call, which 
results in an unrelated error being reported by GetLastError().

Bob
--
Bob Friesenhahn
address@hidden, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/