lzip-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lzip-bug] plzip


From: Tino Lange
Subject: Re: [Lzip-bug] plzip
Date: Fri, 6 May 2016 13:20:42 +0000 (UTC)
User-agent: Pan/0.139 (Sexual Chocolate; GIT bf56508 git://git.gnome.org/pan2)

Hi Antonio,

> Your executables and consolidated patches are welcome. Thank you.

OK, you're welcome: I just sent you the files via private mail.

>> It seems that Hannes Domani has indeed implemented own versions of 
"pread" and "pwrite" and did some more, but only small patches that were 
all not incorporated/merged in the plzip codebase afterwards.
 > [...] I do not have any plans to incorporate Windows code in my 
projects. Would it be possible to incorporate the pread/pwrite 
implementations of Hannes Domani into MinGW? This would solve the problem 
not only for plzip.
 
Sounds like a good idea. But as it is your project and Hannes Domanis 
contributed code, I'm out of that game. One of you two should trigger 
that step. Would that be possible?

Side note: Looking closely it seems that your goal is already missed:
> $ find . -name "*.c" -or -name "*.cc" -or -name "*.h" | xargs grep 
MSVCRT
> ./lunzip/main.c:#if defined(__MSVCRT__)
> ./lunzip/main.c:#if defined(__MSVCRT__) || defined(__OS2__)
> ./lzlib/main.c:#if defined(__MSVCRT__)
> ./lzlib/main.c:#if defined(__MSVCRT__) || defined(__OS2__)
> ./clzip/main.c:#if defined(__MSVCRT__)
> ./clzip/main.c:#if defined(__MSVCRT__) || defined(__OS2__)
> ./lziprecover/main.cc:#if defined(__MSVCRT__)
> ./lziprecover/main.cc:#if defined(__MSVCRT__) || defined(__OS2__)
> ./pdlzip/main.c:#if defined(__MSVCRT__)
> ./pdlzip/main.c:#if defined(__MSVCRT__) || defined(__OS2__)
> ./plzip/main.cc:#if defined(__MSVCRT__)
> ./plzip/main.cc:#if defined(__MSVCRT__) || defined(__OS2__)
> ./lzip/main.cc:#if defined(__MSVCRT__)
> ./lzip/main.cc:#if defined(__MSVCRT__) || defined(__OS2__)
> ./lzd/lzd.cc:#if defined(__MSVCRT__) || defined(__OS2__) || defined
(_MSC_VER)
> ./lzd/lzd.cc:#if defined(__MSVCRT__) || defined(__OS2__) || defined
(_MSC_VER)

-> ALL of your lzip-like projects already incororate Windows specific 
code.

Cheers,

Tino




reply via email to

[Prev in Thread] Current Thread [Next in Thread]