Re: [Lzip-bug] plzip

[Antonio Diaz Diaz]

Tino Lange wrote:
> > Your executables and consolidated patches are welcome. Thank you.
>
> OK, you're welcome: I just sent you the files via private mail.

Thanks. Nice consolidated patches. :-)

I have just uploaded it to 
http://download.savannah.gnu.org/releases/lzip/plzip/


> > Would it be possible to incorporate the pread/pwrite 
> > implementations of Hannes Domani into MinGW? This would solve the
> > problem not only for plzip.
>  
> Sounds like a good idea. But as it is your project and Hannes Domanis 
> contributed code, I'm out of that game. One of you two should trigger 
> that step. Would that be possible?

I have added it to my todo list. I'll try to convince the MinGW people 
to accept the code.


> Side note: Looking closely it seems that your goal is already missed:
>  -> ALL of your lzip-like projects already incororate Windows
> specific code.

A little inaccuracy sometimes saves tons of explanation. ;-)

By "Windows code" I meant "an appreciable amount of ugly Windows code 
that may cause maintenance problems in the future". A few macros and a 
small fragment like:

#if defined(__MSVCRT__) || defined(__OS2__)
  setmode( STDIN_FILENO, O_BINARY );
  setmode( STDOUT_FILENO, O_BINARY );
#endif

that is not even Windows specific, does not qualify as Windows code.


Best regards,
Antonio.