[Octave-bug-tracker] [bug #56752] Performance slowdown from version 3.2.4 through to current dev branch

[Rik]

Follow-up Comment #46, bug #56752 (project octave):

Regarding NoAlias, the number of instances where it is used is quite small: 9
in liboctave and 14 in libinterp.

Speaking personally, I find the pattern of using a function (xelem) rather
than subclassing an object (NoAlias) easier to understand.

jwe has proposed two replacements for NoAlias: 1) using 'const' objects when
read-only access is all that is necessary, 2) using xelem when it is desired
to write elements without causing a check on reference count and possibly
uniquifying the Array.

@jwe: Is that an accurate summary?  Is the existing Array class set up
correctly so that if I use a const constructor I don't end up with two actual
arrays as shown below?


 const ArrayType new_ro_array (existing_array);
 ... intervening code ...
 T element1 = new_ro_array(1);  // Will call new_ro_array.elem()
                                // No problem?


If yes, then I would advocate eliminating NoAlias for readability.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56752>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/