|
| From: | Carlo de Falco |
| Subject: | [Octave-bug-tracker] [bug #56752] Performance slowdown from version 3.2.4 through to current dev branch |
| Date: | Mon, 30 Sep 2019 05:16:13 -0400 (EDT) |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0 |
Follow-up Comment #51, bug #56752 (project octave):
Here's the changeset for removing NoAlias
(better late than never) ...
a few comments :
- there was no usage of NoAlias where the wrapped object
was accessed read-only so in no case I used the const
version of the call operator but all changes consist
of using the xelem () method explicitly
- I think I spotted a few instances in data.cc where NoAlias
was not used but it could have, so xelem could now be used.
I didn't make any changes to those in order not to clutter
this changeset
- I ran __run_test_suite__ () with the changeset applied and see
no extra failures/regressions i the final report
Is it OK to push this?
(file #47587)
_______________________________________________________
Additional Item Attachment:
File name: open_13F4F3id.txt Size:21 KB
<https://savannah.gnu.org/file/open_13F4F3id.txt?file_id=47587>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?56752>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |