[Octave-bug-tracker] [bug #63437] Null pointer dereference in file-editor-tab.cc

[John W. Eaton]

Follow-up Comment #25, bug #63437 (project octave):

"It's OK to change `settings` to a `QSettings` object over time"

The gui_settings object is already derived from QSettings.  It adds no data,
just some additional functions.  The resource_manager stores a single
gui_settings object for use by Octave and provides a pointer to access it.  So
we won't be changing the object that's ultimately used to store the settings. 
We're just changing the way it is used.

For now, there's no need to remove checks to ensure that settings is a valid
pointer.  That's wasted effort since I'll be completely removing the use of a
pointer soon.  So don't bother.  My later edits will remove the checks
anyway.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63437>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/