Re: [Pan-devel] ANN : Tabs support for article overview

[Petr Kovar]

Hi Heinrich,

On Wed, 2 Nov 2011 10:24:01 +0000 (UTC)
Heinrich Müller <address@hidden> wrote:

> Am Mon, 31 Oct 2011 22:44:04 +0100 schrieb Petr Kovar:
> 
> > Hi Heinrich,
> > 
> > On Fri, 28 Oct 2011 10:53:36 +0000 (UTC)
> > Heinrich Müller <address@hidden> wrote:
> > 
> >> Hi guys. I just added tabs support for the article overview tab
> >> for testing. Feel free to test-drive it (branch is tabs).
> > 
> > I think it looks really good, great work! 
> > 
> > I've got some nitpicking suggestions:
> > 
> > When you open Pan, there is now a large blank space displayed instead of the
> > header pane. If it doesn't make sense to display a group with headers there
> > automatically, I'd suggest adding a string like "No group currently opened.
> > \n To open a group, select it in the group pane." Or something like that.
> > 
> > When you move between tabs, the actual change of the current group isn't
> > reflected in the group pane - IOW the selected group in the group pane
> > doesn't reflect the selected tab in the header pane (article overview). 
> > 
> > The red close button on a tab is really large, could it be made a little bit
> > smaller perhaps? 
> > 
> > I'd suggest moving the "Wrapping:" status from an extra bar of its own to
> > the status bar below, perhaps right to the Task field in the status bar so
> > that it doesn't occupy unnecessary space in GUI. (Think of tablets etc. BTW
> > Pan compiles on MeeGo too.)
> > 
> > Thanks again and keep up the good work!
> > 
> > Cheers,
> > Petr Kovar
> 
> Hi Petr.
> I'm done, except for the the text filter which gives me some headaches.
> The rest should work...

Excellent, thank you!

Some other things I've spotted:

When you select a group and open it, the "Welcome to pan" tab (I'd rephrase
the app name to Pan) is not closed automatically. I suggest replacing the
welcome tab with the tab of a group that is being opened.

I'd rephrase the text label to something like "Welcome to Pan. To start
newsreading, select a group or add a news server." Just nitpicking here,
anyway. :)

As with Firefox and other popular apps with tabs, I'd like to be able to
configure switching to a newly opened tab automatically. And perhaps make
the automatic switching default.

I'd be nice to have the display of the whole tab bar configurable as well.

The changing of the currently selected group based on the active tab still
doesn't work for me when moving between tabs, unfortunately. 

Also, the close buttons on tabs are still huge, maybe this is related to
GTK+ themes or so, and not to Pan code directly? I can surely live with
that, just saying.

Thanks again,
Petr Kovar