Re: [Plash] Plash 1.18 released

[Mark Seaborn]

Thomas Leonard <address@hidden> wrote:

> On 05/06/2007, Thomas Leonard <address@hidden> wrote:
> > Thanks. BTW, if you want some free unit tests, the Zero Install ones
> > detect this problem:
> 
> Note that the tests have now moved to GIT:
> 
> $ git-clone git://repo.or.cz/zeroinstall.git
> $ cd zeroinstall/tests
> $ ./testall.py

Thanks for letting me know.  I still need to set up my continuous
integration system to run those tests.

By the way, when I run those tests without HOME set to a valid
directory, I get a traceback:

Traceback (most recent call last):
  File "./testall.py", line 24, in ?
    m = __import__(name, globals(), locals(), [])
  File "/work/working/plash/zeroinstall/tests/testalias.py", line 2, in ?
    from basetest import BaseTest
  File "/work/working/plash/zeroinstall/tests/basetest.py", line 7, in ?
    from zeroinstall.injector import trust, basedir, autopolicy, namespaces
  File "../zeroinstall/injector/autopolicy.py", line 15, in ?
    from zeroinstall.injector import model, policy, run
  File "../zeroinstall/injector/policy.py", line 17, in ?
    import reader
  File "../zeroinstall/injector/reader.py", line 15, in ?
    from zeroinstall.injector import basedir, qdom, distro
  File "../zeroinstall/injector/distro.py", line 235, in ?
    host_distribution = DebianDistribution(_dpkg_db_dir)
  File "../zeroinstall/injector/distro.py", line 51, in __init__
    self.cache_dir = basedir.save_cache_path(namespaces.config_site, 
namespaces.config_prog)
  File "../zeroinstall/injector/basedir.py", line 73, in save_cache_path
    os.makedirs(path, 0700)
  File "/usr/lib/python2.4/os.py", line 156, in makedirs
    makedirs(head, mode)
  File "/usr/lib/python2.4/os.py", line 156, in makedirs
    makedirs(head, mode)
  File "/usr/lib/python2.4/os.py", line 156, in makedirs
    makedirs(head, mode)
  File "/usr/lib/python2.4/os.py", line 159, in makedirs
    mkdir(name, mode)
OSError: [Errno 13] Permission denied: '/home/mrs'

That was in a chroot where HOME was inherited and not properly reset.


> However, they still hang when used with the latest plash:
> 
> $ dpkg --status plash
> Version: 1.18.svn.2007-11-20-1652-1gutsy1
> 
> Plash seems to have trouble when stderr isn't writeable:
> 
> $ cat hi
> cat: hi: No such file or directory
> $ cat hi 2</dev/null
> $ pola-run -B -e cat hi 2</dev/null
> [ hangs ]

Thanks for pointing that out.  The whole area of FD forwarding is a
bit of a minefield.  It's a lot harder than it first seems because of
all the corner cases.  I'm working on it at the moment.  This
particular problem had not occurred to me.  I've added a note to
<http://plash.beasts.org/wiki/EventLoopAndFDs>.

I'm currently working on fixing
<http://plash.beasts.org/wiki/PlashIssues/StdoutGetsTruncated>.

Regards,
Mark