Re: [Plash] Plash 1.18 released

[Mark Seaborn]

Thomas Leonard <address@hidden> wrote:

> Plash seems to have trouble when stderr isn't writeable:
> 
> $ cat hi
> cat: hi: No such file or directory
> $ cat hi 2</dev/null
> $ pola-run -B -e cat hi 2</dev/null
> [ hangs ]

This is now fixed, and the Zero-Install tests now all pass with Plash
installed.  I suspect that what you might have intended in the test
that caught this issue was to use O_WRONLY -- see patch below, though
I'm not suggesting it's worth applying.

Regards,
Mark

diff --git a/tests/testunpack.py b/tests/testunpack.py
index a07be1c..0d2b37f 100755
--- a/tests/testunpack.py
+++ b/tests/testunpack.py
@@ -47,7 +47,7 @@ class AbstractTestUnpack(BaseTest):
        def testExtractFails(self):
                stderr = os.dup(2)
                try:
-                       null = os.open('/dev/null', os.O_RDONLY)
+                       null = os.open('/dev/null', os.O_WRONLY)
                        os.close(2)
                        os.dup2(null, 2)
                        try: