[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 17/23] target/arm: Fix coding style issues
From: |
Alex Bennée |
Subject: |
Re: [Qemu-arm] [PATCH v2 17/23] target/arm: Fix coding style issues |
Date: |
Mon, 17 Jun 2019 15:20:08 +0100 |
User-agent: |
mu4e 1.3.2; emacs 26.1 |
Philippe Mathieu-Daudé <address@hidden> writes:
> Since we'll move this code around, fix its style first.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/arm/translate.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index c274c8b460..d0ab3e27e6 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -9179,7 +9179,7 @@ static void disas_arm_insn(DisasContext *s, unsigned
> int insn)
> loaded_base = 0;
> loaded_var = NULL;
> n = 0;
> - for(i=0;i<16;i++) {
> + for (i = 0; i < 16; i++) {
> if (insn & (1 << i))
> n++;
> }
> @@ -9202,7 +9202,7 @@ static void disas_arm_insn(DisasContext *s, unsigned
> int insn)
> }
> }
> j = 0;
> - for(i=0;i<16;i++) {
> + for (i = 0; i < 16; i++) {
> if (insn & (1 << i)) {
> if (is_load) {
> /* load */
> @@ -12427,12 +12427,13 @@ void arm_cpu_dump_state(CPUState *cs, FILE *f, int
> flags)
> return;
> }
>
> - for(i=0;i<16;i++) {
> + for (i = 0; i < 16; i++) {
> qemu_fprintf(f, "R%02d=%08x", i, env->regs[i]);
> - if ((i % 4) == 3)
> + if ((i % 4) == 3) {
> qemu_fprintf(f, "\n");
> - else
> + } else {
> qemu_fprintf(f, " ");
> + }
> }
>
> if (arm_feature(env, ARM_FEATURE_M)) {
--
Alex Bennée
- [Qemu-arm] [PATCH v2 08/23] target/arm: Move all v7m insn helpers into their own file, (continued)
- [Qemu-arm] [PATCH v2 08/23] target/arm: Move all v7m insn helpers into their own file, Philippe Mathieu-Daudé, 2019/06/15
- [Qemu-arm] [PATCH v2 13/23] target/arm: Make the v7-M Security State routines, Philippe Mathieu-Daudé, 2019/06/15
- [Qemu-arm] [PATCH v2 15/23] target/arm: Make ARM TLB filling routine static, Philippe Mathieu-Daudé, 2019/06/15
- [Qemu-arm] [PATCH v2 16/23] target/arm: Make arm_deliver_fault() static, Philippe Mathieu-Daudé, 2019/06/15
- [Qemu-arm] [PATCH v2 17/23] target/arm: Fix coding style issues, Philippe Mathieu-Daudé, 2019/06/15
- Re: [Qemu-arm] [PATCH v2 17/23] target/arm: Fix coding style issues,
Alex Bennée <=
- [Qemu-arm] [PATCH v2 18/23] target/arm: Move CPU state dumping routines to helper.c, Philippe Mathieu-Daudé, 2019/06/15
- [Qemu-arm] [PATCH v2 19/23] target/arm: Move watchpoints APIs to helper.c, Philippe Mathieu-Daudé, 2019/06/15
- [Qemu-arm] [PATCH v2 20/23] target/arm: Define TCG dependent functions when TCG is enabled, Philippe Mathieu-Daudé, 2019/06/15
- [Qemu-arm] [PATCH v2 21/23] target/arm: Do not build TCG objects when TCG is off, Philippe Mathieu-Daudé, 2019/06/15