[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "" |
|
Date: |
Tue, 20 Mar 2018 13:41:17 +0000 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Mar 20, 2018 at 02:32:16PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > So for these, we should use "". None of these are generated files though.
> >
> > That leads to crazy inconsistent message for developers where 50% of QEMU
> > header files must use <> and the other 50% of header files must use "".
>
> The rules are pretty simple though:
>
> (1) Headers which are generated use <>.
> (2) Headers which are in include/ use <>.
> (3) Headers sitting in the same directory as the source files use "".
We have 1200 header files in QEMU - a developer might just reasonably remember
which header file is a QEMU header, vs which is a 3rd party system header.
Expecting devs to remember which of those 3 buckets each QEMU header falls
under is unreasonable IMHO.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", (continued)
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Laurent Vivier, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Gerd Hoffmann, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Thomas Huth, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "",
Daniel P . Berrangé <=
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Max Reitz, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Peter Maydell, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20