[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "" |
|
Date: |
Tue, 20 Mar 2018 14:32:16 +0100 |
|
User-agent: |
NeoMutt/20180223 |
Hi,
> > So for these, we should use "". None of these are generated files though.
>
> That leads to crazy inconsistent message for developers where 50% of QEMU
> header files must use <> and the other 50% of header files must use "".
The rules are pretty simple though:
(1) Headers which are generated use <>.
(2) Headers which are in include/ use <>.
(3) Headers sitting in the same directory as the source files use "".
Other cases should not exist (when headers from another source directory
are included they should most likely be moved to include/).
cheers,
Gerd
- [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Laurent Vivier, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "",
Gerd Hoffmann <=
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Thomas Huth, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Max Reitz, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Peter Maydell, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20