[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "" |
Date: |
Tue, 20 Mar 2018 19:12:59 +0200 |
On Tue, Mar 20, 2018 at 02:54:37PM +0100, Max Reitz wrote:
> But I guess the main advantage with using this rule I see is that it's
> better for people reading the code. It's just nice to know whether a
> file belongs to qemu or not by just looking at the #include statement.
> (Note that this implies that it is indeed more difficult to determine
> whether a header belongs to qemu than whether it sits in the same
> directory as the C file, though!) So I think the old (current) rule is
> better for reading code, Michael's rule would be better for writing
> code. I think reading code is what should be easier.
How about prefixing all internal headers with qemu/ ?
That's a way to avoid namespace collisions that is actually standard.
--
MST
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", (continued)
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Gerd Hoffmann, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Thomas Huth, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Max Reitz, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "",
Michael S. Tsirkin <=
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Peter Maydell, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/20
- Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/20
Re: [Qemu-block] [Qemu-ppc] [PATCH] qemu: include generated files with <> and not "", Daniel P . Berrangé, 2018/03/21
Re: [Qemu-block] [Qemu-ppc] [PATCH] qemu: include generated files with <> and not "", Michael S. Tsirkin, 2018/03/21