[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple u
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple union tag |
Date: |
Wed, 7 Feb 2024 08:20:09 +0000 |
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Mon, Feb 05, 2024 at 08:46:59AM +0100, Markus Armbruster wrote:
> QAPISchemaGenRSTVisitor._nodes_for_members() has a special case to
> auto-generate documentation for a union tag member of implicit (enum)
> type that lacks documentation.
>
> This was useful for simple unions, where the tag member's type was
> implicitly. The only implicit enum type left today is 'QType'. Not
> worth a special case. Drop. No change to generated documentation.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/sphinx/qapidoc.py | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 10/15] qapi/yank: Clean up documentaion of yank, (continued)
- [PATCH 10/15] qapi/yank: Clean up documentaion of yank, Markus Armbruster, 2024/02/05
- [PATCH 14/15] qapi: Move @String out of common.json to discourage reuse, Markus Armbruster, 2024/02/05
- [PATCH 12/15] qapi: Plug trivial documentation holes around former simple unions, Markus Armbruster, 2024/02/05
- [PATCH 07/15] qga/qapi-schema: Clean up documentation of guest-set-memory-blocks, Markus Armbruster, 2024/02/05
- [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple union tag, Markus Armbruster, 2024/02/05
- Re: [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple union tag,
Daniel P . Berrangé <=
- [PATCH 13/15] qapi: Improve documentation of file descriptor socket addresses, Markus Armbruster, 2024/02/05
- [PATCH 01/15] docs/devel/qapi-code-gen: Normalize version refs x.y.0 to just x.y, Markus Armbruster, 2024/02/05
- [PATCH 09/15] qga/qapi-schema: Plug trivial documentation holes, Markus Armbruster, 2024/02/05
- Re: [PATCH 00/15] qapi: Require member documentation (with loophole), Peter Xu, 2024/02/06