qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple u


From: Daniel P . Berrangé
Subject: Re: [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple union tag
Date: Wed, 7 Feb 2024 08:20:09 +0000
User-agent: Mutt/2.2.12 (2023-09-09)

On Mon, Feb 05, 2024 at 08:46:59AM +0100, Markus Armbruster wrote:
> QAPISchemaGenRSTVisitor._nodes_for_members() has a special case to
> auto-generate documentation for a union tag member of implicit (enum)
> type that lacks documentation.
> 
> This was useful for simple unions, where the tag member's type was
> implicitly.  The only implicit enum type left today is 'QType'.  Not
> worth a special case.  Drop.  No change to generated documentation.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/sphinx/qapidoc.py | 6 ------
>  1 file changed, 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]