qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/15] qapi: Plug trivial documentation holes around former s


From: Daniel P . Berrangé
Subject: Re: [PATCH 12/15] qapi: Plug trivial documentation holes around former simple unions
Date: Wed, 7 Feb 2024 08:36:32 +0000
User-agent: Mutt/2.2.12 (2023-09-09)

On Mon, Feb 05, 2024 at 08:47:06AM +0100, Markus Armbruster wrote:
> The conversion of simple to flat unions left the @data members
> undocumented.  Add documentation where it's trivial.  Copy verbatim
> from the wrapped type's description where possible.
> 
> Leftovers: String (to be taken care of in the next commit), and
> TransActionAction (left for another day).
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/block-core.json | 10 ++++++++++
>  qapi/char.json       | 26 ++++++++++++++++++++++++++
>  qapi/machine.json    | 10 ++++++++++
>  qapi/pragma.json     | 34 ----------------------------------
>  qapi/sockets.json    |  6 ++++++
>  qapi/tpm.json        |  4 ++++
>  qapi/ui.json         | 12 ++++++++++++
>  7 files changed, 68 insertions(+), 34 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]