Re: [PATCH 13/15] qapi: Improve documentation of file descriptor socket addresses

[Daniel P . Berrangé]

On Mon, Feb 05, 2024 at 08:47:07AM +0100, Markus Armbruster wrote:
> SocketAddress branch @fd is documented in enum SocketAddressType,
> unlike the other branches.  That's because the branch's type is String
> from common.json.
> 
> Use a local copy of String, so we can put the documentation in the
> usual place.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/sockets.json                      | 40 +++++++++++++++++---------
>  include/hw/virtio/vhost-vsock-common.h |  1 +
>  chardev/char-socket.c                  |  2 +-
>  util/qemu-sockets.c                    |  3 +-
>  4 files changed, 31 insertions(+), 15 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|