|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints |
Date: | Fri, 29 Aug 2014 09:42:17 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/29/2014 04:21 AM, Peter Maydell wrote: > + /* Watchpoint covers an aligned area up to 2GB in size */ > + len = 1ULL << mask; > + /* If masked bits in WVR are not zero it's CONSTRAINED UNPREDICTABLE > + * whether the watchpoint fires when the unmasked bits match; we opt > + * to generate the exceptions. > + */ > + wvr &= (len - 1); This looks funny... address being clipped to length? Surely it's ~(len - 1)... r~
[Prev in Thread] | Current Thread | [Next in Thread] |