[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoi
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints |
Date: |
Fri, 29 Aug 2014 17:43:43 +0100 |
On 29 August 2014 17:42, Richard Henderson <address@hidden> wrote:
> On 08/29/2014 04:21 AM, Peter Maydell wrote:
>> + /* Watchpoint covers an aligned area up to 2GB in size */
>> + len = 1ULL << mask;
>> + /* If masked bits in WVR are not zero it's CONSTRAINED UNPREDICTABLE
>> + * whether the watchpoint fires when the unmasked bits match; we opt
>> + * to generate the exceptions.
>> + */
>> + wvr &= (len - 1);
>
> This looks funny... address being clipped to length?
> Surely it's ~(len - 1)...
Nice catch. Linux doesn't actually use this bit of the watchpoint
functionality, which is why I didn't notice.
-- PMM
- [Qemu-devel] [PATCH 00/10] Implement ARM architectural watchpoints, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 09/10] target-arm: Remove comment about MDSCR_EL1 being dummy implementation, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 10/10] target-arm: Implement minimal DBGVCR, OSDLR_EL1, MDCCSR_EL0, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 03/10] exec.c: Record watchpoint fault address and direction, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 06/10] target-arm: Move extended_addresses_enabled() to internals.h, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 08/10] target-arm: Set DBGDSCR.MOE for debug exceptions taken to AArch32, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 01/10] exec.c: Relax restrictions on watchpoint length and alignment, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 07/10] target-arm: Implement handling of fired watchpoints, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 02/10] exec.c: Provide full set of dummy wp remove functions in user-mode, Peter Maydell, 2014/08/29
- [Qemu-devel] [PATCH 04/10] cpu-exec: Make debug_excp_handler a QOM CPU method, Peter Maydell, 2014/08/29
- Re: [Qemu-devel] [PATCH 00/10] Implement ARM architectural watchpoints, Richard Henderson, 2014/08/29