[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/13] target/arm: Correct definition of PMCRDP
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 12/13] target/arm: Correct definition of PMCRDP |
|
Date: |
Tue, 11 Feb 2020 10:52:19 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/11/20 9:37 AM, Peter Maydell wrote:
> The PMCR_EL0.DP bit is bit 5, which is 0x20, not 0x10. 0x10 is 'X'.
> Correct our #define of PMCRDP and add the missing PMCRX.
>
> We do have the correct behaviour for handling the DP bit being
> set, so this fixes a guest-visible bug.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target/arm/helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [PATCH 04/13] target/arm: Factor out PMU register definitions, (continued)
- [PATCH 10/13] target/arm: Implement ARMv8.4-PMU extension, Peter Maydell, 2020/02/11
- [PATCH 07/13] target/arm: Define an aa32_pmu_8_1 isar feature test function, Peter Maydell, 2020/02/11
- [PATCH 08/13] target/arm: Add _aa64_ and _any_ versions of pmu_8_1 isar checks, Peter Maydell, 2020/02/11
- [PATCH 12/13] target/arm: Correct definition of PMCRDP, Peter Maydell, 2020/02/11
- [PATCH 11/13] target/arm: Provide ARMv8.4-PMU in '-cpu max', Peter Maydell, 2020/02/11