[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/17] target/arm: Replace ARM_FEATURE_VFP4 with isar_feat
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 09/17] target/arm: Replace ARM_FEATURE_VFP4 with isar_feature_aa32_simdfmac |
|
Date: |
Tue, 25 Feb 2020 13:25:25 +0000 |
On Mon, 24 Feb 2020 at 22:22, Richard Henderson
<address@hidden> wrote:
>
> All remaining tests for VFP4 are for fused multiply-add insns.
>
> Since the MVFR1 field is used for both VFP and NEON, move its adjustment
> from the !has_neon block to the (!has_vfp && !has_neon) block.
>
> Test for vfp of the appropraite width alongside the test for simdfmac
"appropriate"
> within translate-vfp.inc.c. Within disas_neon_data_insn, we have
> already tested for ARM_FEATURE_NEON.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [PATCH v2 01/17] target/arm: Add isar_feature_aa32_vfp_simd, (continued)
- [PATCH v2 01/17] target/arm: Add isar_feature_aa32_vfp_simd, Richard Henderson, 2020/02/24
- [PATCH v2 05/17] target/arm: Improve ID_AA64PFR0 FP/SIMD validation, Richard Henderson, 2020/02/24
- [PATCH v2 04/17] target/arm: Add isar_feature_aa64_fp_simd, isar_feature_aa32_vfp, Richard Henderson, 2020/02/24
- [PATCH v2 07/17] target/arm: Replace ARM_FEATURE_VFP3 checks with fp{sp, dp}_v3, Richard Henderson, 2020/02/24
- [PATCH v2 06/17] target/arm: Perform fpdp_v2 check first, Richard Henderson, 2020/02/24
- [PATCH v2 08/17] target/arm: Add missing checks for fpsp_v2, Richard Henderson, 2020/02/24
- [PATCH v2 09/17] target/arm: Replace ARM_FEATURE_VFP4 with isar_feature_aa32_simdfmac, Richard Henderson, 2020/02/24
- Re: [PATCH v2 09/17] target/arm: Replace ARM_FEATURE_VFP4 with isar_feature_aa32_simdfmac,
Peter Maydell <=
- [PATCH v2 10/17] target/arm: Remove ARM_FEATURE_VFP check from disas_vfp_insn, Richard Henderson, 2020/02/24
- [PATCH v2 11/17] target/arm: Move VLLDM and VLSTM to vfp.decode, Richard Henderson, 2020/02/24
- [PATCH v2 12/17] target/arm: Move the vfp decodetree calls next to the base isa, Richard Henderson, 2020/02/24
- [PATCH v2 13/17] linux-user/arm: Replace ARM_FEATURE_VFP* tests for HWCAP, Richard Henderson, 2020/02/24
- [PATCH v2 14/17] target/arm: Remove ARM_FEATURE_VFP*, Richard Henderson, 2020/02/24
- [PATCH v2 16/17] target/arm: Split VFM decode, Richard Henderson, 2020/02/24
- [PATCH v2 15/17] target/arm: Add formats for some vfp 2 and 3-register insns, Richard Henderson, 2020/02/24