[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-c
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 8/9] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c |
|
Date: |
Thu, 1 Dec 2022 08:57:20 +0000 |
|
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Thu, Dec 01, 2022 at 07:13:10AM +0100, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/monitor/hmp.h | 5 +++++
> monitor/hmp-cmds.c | 28 +---------------------------
> ui/ui-hmp-cmds.c | 19 +++++++++++++++----
> 3 files changed, 21 insertions(+), 31 deletions(-)
If you pull in the hmp_change_vnc impl from the previous patch
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 4/9] ui: Clean up a few things checkpatch.pl would flag later on, (continued)
- [PATCH 4/9] ui: Clean up a few things checkpatch.pl would flag later on, Markus Armbruster, 2022/12/01
- [PATCH 1/9] ui: Check numeric part of expire_password argument @time properly, Markus Armbruster, 2022/12/01
- [PATCH 2/9] ui: Fix silent truncation of numeric keys in HMP sendkey, Markus Armbruster, 2022/12/01
- [PATCH 7/9] ui: Improve "change vnc" error reporting, Markus Armbruster, 2022/12/01
- [PATCH 8/9] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c, Markus Armbruster, 2022/12/01
- Re: [PATCH 8/9] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c,
Daniel P . Berrangé <=
- [PATCH 6/9] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c, Markus Armbruster, 2022/12/01
- [PATCH 9/9] ui: Reduce nesting in hmp_change_vnc() slightly, Markus Armbruster, 2022/12/01
- [PATCH 5/9] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c, Markus Armbruster, 2022/12/01