[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 9/9] ui: Reduce nesting in hmp_change_vnc() slightly
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 9/9] ui: Reduce nesting in hmp_change_vnc() slightly |
Date: |
Thu, 1 Dec 2022 08:58:13 +0000 |
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Thu, Dec 01, 2022 at 07:13:11AM +0100, Markus Armbruster wrote:
> Transform
>
> if (good) {
> do stuff
> } else {
> handle error
> }
>
> to
>
> if (!good) {
> handle error
> return;
> }
> do stuff
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/ui-hmp-cmds.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 7/9] ui: Improve "change vnc" error reporting, (continued)