Re: [PATCH 6/9] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 1/12/22 07:13, Markus Armbruster wrote:
>> This moves these commands from MAINTAINERS section "Human
>> Monitor (HMP)" to "Graphics".
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>   monitor/hmp-cmds.c | 342 ------------------------------------------
>>   ui/ui-hmp-cmds.c   | 360 +++++++++++++++++++++++++++++++++++++++++++++
>>   ui/meson.build     |   1 +
>>   3 files changed, 361 insertions(+), 342 deletions(-)
>>   create mode 100644 ui/ui-hmp-cmds.c
>
>
>> +#ifdef CONFIG_SPICE
>> +void hmp_info_spice(Monitor *mon, const QDict *qdict)
>> +{
>> +    SpiceChannelList *chan;
>> +    SpiceInfo *info;
>> +    const char *channel_name;
>> +    const char * const channel_names[] = {
>
> Can be static (pre-existing).

Separate patch, to keep the code motion pure.

>> +        [SPICE_CHANNEL_MAIN] = "main",
>> +        [SPICE_CHANNEL_DISPLAY] = "display",
>> +        [SPICE_CHANNEL_INPUTS] = "inputs",
>> +        [SPICE_CHANNEL_CURSOR] = "cursor",
>> +        [SPICE_CHANNEL_PLAYBACK] = "playback",
>> +        [SPICE_CHANNEL_RECORD] = "record",
>> +        [SPICE_CHANNEL_TUNNEL] = "tunnel",
>> +        [SPICE_CHANNEL_SMARTCARD] = "smartcard",
>> +        [SPICE_CHANNEL_USBREDIR] = "usbredir",
>> +        [SPICE_CHANNEL_PORT] = "port",
>> +    };
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!