[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/6] aspeed/sdmc: Check RAM size value at realize time
From: |
Cédric Le Goater |
Subject: |
[PULL 3/6] aspeed/sdmc: Check RAM size value at realize time |
Date: |
Tue, 2 Jul 2024 10:00:39 +0200 |
The RAM size of the SDMC device is validated for the SoC and set when
the Aspeed machines are initialized and then later used by several
SoC implementations. However, the SDMC model never checks that the RAM
size has been actually set before being used. Do that at realize.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Jamin_lin < jamin_lin@aspeedtech.com>
---
hw/misc/aspeed_sdmc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index 93e2e29ead87..44da085e10cb 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -271,6 +271,12 @@ static void aspeed_sdmc_realize(DeviceState *dev, Error
**errp)
AspeedSDMCClass *asc = ASPEED_SDMC_GET_CLASS(s);
assert(asc->max_ram_size < 4 * GiB || asc->is_bus64bit);
+
+ if (!s->ram_size) {
+ error_setg(errp, "RAM size is not set");
+ return;
+ }
+
s->max_ram_size = asc->max_ram_size;
memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_sdmc_ops, s,
--
2.45.2
- [PULL 0/6] aspeed queue, Cédric Le Goater, 2024/07/02
- [PULL 3/6] aspeed/sdmc: Check RAM size value at realize time,
Cédric Le Goater <=
- [PULL 1/6] hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass, Cédric Le Goater, 2024/07/02
- [PULL 2/6] aspeed: Deprecate the tacoma-bmc machine, Cédric Le Goater, 2024/07/02
- [PULL 4/6] aspeed/soc: Fix possible divide by zero, Cédric Le Goater, 2024/07/02
- [PULL 6/6] hw/net:ftgmac100: fix coding style, Cédric Le Goater, 2024/07/02
- [PULL 5/6] aspeed/sdmc: Remove extra R_MAIN_STATUS case, Cédric Le Goater, 2024/07/02
- Re: [PULL 0/6] aspeed queue, Richard Henderson, 2024/07/02