[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/6] aspeed/sdmc: Remove extra R_MAIN_STATUS case
From: |
Cédric Le Goater |
Subject: |
[PULL 5/6] aspeed/sdmc: Remove extra R_MAIN_STATUS case |
Date: |
Tue, 2 Jul 2024 10:00:41 +0200 |
From: Jamin Lin <jamin_lin@aspeedtech.com>
Coverity reports that the newly added 'case R_MAIN_STATUS' is DEADCODE
because it can not be reached. This is because R_MAIN_STATUS is handled
before in the "Unprotected registers" switch statement. Remove it.
Fixes: Coverity CID 1547112
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
[ clg: Rewrote commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/misc/aspeed_sdmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index 44da085e10cb..ebf139cb5c91 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -595,7 +595,6 @@ static void aspeed_2700_sdmc_write(AspeedSDMCState *s,
uint32_t reg,
case R_INT_STATUS:
case R_INT_CLEAR:
case R_INT_MASK:
- case R_MAIN_STATUS:
case R_ERR_STATUS:
case R_ECC_FAIL_STATUS:
case R_ECC_FAIL_ADDR:
--
2.45.2
- [PULL 0/6] aspeed queue, Cédric Le Goater, 2024/07/02
- [PULL 3/6] aspeed/sdmc: Check RAM size value at realize time, Cédric Le Goater, 2024/07/02
- [PULL 1/6] hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass, Cédric Le Goater, 2024/07/02
- [PULL 2/6] aspeed: Deprecate the tacoma-bmc machine, Cédric Le Goater, 2024/07/02
- [PULL 4/6] aspeed/soc: Fix possible divide by zero, Cédric Le Goater, 2024/07/02
- [PULL 6/6] hw/net:ftgmac100: fix coding style, Cédric Le Goater, 2024/07/02
- [PULL 5/6] aspeed/sdmc: Remove extra R_MAIN_STATUS case,
Cédric Le Goater <=
- Re: [PULL 0/6] aspeed queue, Richard Henderson, 2024/07/02