[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/6] aspeed/soc: Fix possible divide by zero
From: |
Cédric Le Goater |
Subject: |
[PULL 4/6] aspeed/soc: Fix possible divide by zero |
Date: |
Tue, 2 Jul 2024 10:00:40 +0200 |
From: Jamin Lin <jamin_lin@aspeedtech.com>
Coverity reports a possible DIVIDE_BY_ZERO issue regarding the
"ram_size" object property. This can not happen because RAM has
predefined valid sizes per SoC. Nevertheless, add a test to
close the issue.
Fixes: Coverity CID 1547113
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
[ clg: Rewrote commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/arm/aspeed_ast27x0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index b6876b4862ff..18e6a8b10cae 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -211,6 +211,8 @@ static void aspeed_ram_capacity_write(void *opaque, hwaddr
addr, uint64_t data,
ram_size = object_property_get_uint(OBJECT(&s->sdmc), "ram-size",
&error_abort);
+ assert(ram_size > 0);
+
/*
* Emulate ddr capacity hardware behavior.
* If writes the data to the address which is beyond the ram size,
--
2.45.2
- [PULL 0/6] aspeed queue, Cédric Le Goater, 2024/07/02
- [PULL 3/6] aspeed/sdmc: Check RAM size value at realize time, Cédric Le Goater, 2024/07/02
- [PULL 1/6] hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass, Cédric Le Goater, 2024/07/02
- [PULL 2/6] aspeed: Deprecate the tacoma-bmc machine, Cédric Le Goater, 2024/07/02
- [PULL 4/6] aspeed/soc: Fix possible divide by zero,
Cédric Le Goater <=
- [PULL 6/6] hw/net:ftgmac100: fix coding style, Cédric Le Goater, 2024/07/02
- [PULL 5/6] aspeed/sdmc: Remove extra R_MAIN_STATUS case, Cédric Le Goater, 2024/07/02
- Re: [PULL 0/6] aspeed queue, Richard Henderson, 2024/07/02