Re: [PATCH v2 2/9] hw/riscv/virt-acpi-build.c: Update the HID of RISC-V UART

[Sunil V L]

On Thu, Jul 11, 2024 at 10:41:35AM -0400, Michael S. Tsirkin wrote:
> On Thu, Jul 11, 2024 at 03:25:12PM +0200, Igor Mammedov wrote:
> > On Mon,  8 Jul 2024 17:17:34 +0530
> > Sunil V L <sunilvl@ventanamicro.com> wrote:
> > 
> > > The RISC-V BRS specification [1] requires NS16550 compatible UART to
> > > have the HID RSCV0003. So, update the HID for the UART.
> > > 
> > > [1] - https://github.com/riscv-non-isa/riscv-brs
> > 
> > it point's repo with a bunch of files,
> > please make it easier for reader to find
> > aka point to concrete document + title (for when link goes stale)
> > and chapter. (similar to what we do for when documenting ACPI code)
> > 
> > > 
> > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> > > Acked-by: Alistair Francis <alistair.francis@wdc.com>
> > > ---
> > >  hw/riscv/virt-acpi-build.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c
> > > index 87fe882af0..939f951e45 100644
> > > --- a/hw/riscv/virt-acpi-build.c
> > > +++ b/hw/riscv/virt-acpi-build.c
> > > @@ -192,7 +192,7 @@ acpi_dsdt_add_uart(Aml *scope, const MemMapEntry 
> > > *uart_memmap,
> > >                      uint32_t uart_irq)
> > >  {
> > >      Aml *dev = aml_device("COM0");
> > > -    aml_append(dev, aml_name_decl("_HID", aml_string("PNP0501")));
> > > +    aml_append(dev, aml_name_decl("_HID", aml_string("RSCV0003")));
> > >      aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> 
> 
> In fact, adding the link to the document here would be best.
> Pls link to the earliest version that lists this id,
> cite version and chapter in the document.
> Thanks!
> 
Thanks Michael and Igor!. I will address your comments on the series and
send next version.

Thanks,
Sunil