qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/7] Code motion: expose some TCG definitions for page tab


From: Richard Henderson
Subject: Re: [PATCH v4 1/7] Code motion: expose some TCG definitions for page table walk consolidation.
Date: Wed, 24 Jul 2024 13:14:54 +1000
User-agent: Mozilla Thunderbird

On 7/23/24 11:05, Don Porter wrote:
Signed-off-by: Don Porter <porter@cs.unc.edu>
---
  include/hw/core/sysemu-cpu-ops.h     |  6 +++++
  target/i386/cpu.h                    |  5 ++--
  target/i386/helper.c                 | 36 +++++++++++++++++++++++++++
  target/i386/tcg/helper-tcg.h         | 32 ++++++++++++++++++++++++
  target/i386/tcg/seg_helper.c         | 36 ---------------------------
  target/i386/tcg/sysemu/excp_helper.c | 37 +---------------------------
  6 files changed, 77 insertions(+), 75 deletions(-)

diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h
index 24d003fe04..4c94e51267 100644
--- a/include/hw/core/sysemu-cpu-ops.h
+++ b/include/hw/core/sysemu-cpu-ops.h
@@ -12,6 +12,12 @@
#include "hw/core/cpu.h" +typedef enum TranslateFaultStage2 {
+    S2_NONE,
+    S2_GPA,
+    S2_GPT,
+} TranslateFaultStage2;

No, you can't move an x86-specific item like this into common code.
You're doing something wrong in the abstraction.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]