[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 03/11] usb/msd: Ensure packet structure layout is correct
From: |
Nicholas Piggin |
Subject: |
[PATCH 03/11] usb/msd: Ensure packet structure layout is correct |
Date: |
Thu, 12 Dec 2024 19:13:14 +1000 |
These structures are hardware interfaces, ensure the layout is
correct.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
hw/usb/dev-storage.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 2d7306b0572..87c22476f6b 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -27,7 +27,7 @@
#define MassStorageReset 0xff
#define GetMaxLun 0xfe
-struct usb_msd_cbw {
+struct QEMU_PACKED usb_msd_cbw {
uint32_t sig;
uint32_t tag;
uint32_t data_len;
@@ -636,6 +636,9 @@ static const TypeInfo usb_storage_dev_type_info = {
static void usb_msd_register_types(void)
{
+ qemu_build_assert(sizeof(struct usb_msd_cbw) == 31);
+ qemu_build_assert(sizeof(struct usb_msd_csw) == 13);
+
type_register_static(&usb_storage_dev_type_info);
}
--
2.45.2
- [PATCH 00/11] usb/msd: Permit relaxed ordering of IN packets, Nicholas Piggin, 2024/12/12
- [PATCH 01/11] usb/msd: Add status to usb_msd_packet_complete() function, Nicholas Piggin, 2024/12/12
- [PATCH 03/11] usb/msd: Ensure packet structure layout is correct,
Nicholas Piggin <=
- [PATCH 02/11] usb/msd: Split in and out packet handling, Nicholas Piggin, 2024/12/12
- [PATCH 04/11] usb/msd: Improved handling of mass storage reset, Nicholas Piggin, 2024/12/12
- [PATCH 05/11] usb/msd: Improve packet validation error logging, Nicholas Piggin, 2024/12/12
- [PATCH 06/11] usb/msd: Allow CBW packet size greater than 31, Nicholas Piggin, 2024/12/12
- [PATCH 07/11] usb/msd: Split async packet tracking into data and csw, Nicholas Piggin, 2024/12/12
- [PATCH 08/11] usb/msd: Add some additional assertions, Nicholas Piggin, 2024/12/12
- [PATCH 09/11] usb/msd: Rename mode to cbw_state, and tweak names, Nicholas Piggin, 2024/12/12
- [PATCH 10/11] usb/msd: Permit a DATA-IN or CSW packet before CBW packet, Nicholas Piggin, 2024/12/12
- [PATCH 11/11] usb/msd: Add more tracing, Nicholas Piggin, 2024/12/12