[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/13] target/i386: optimize CX handling in repeated string opera
From: |
Paolo Bonzini |
Subject: |
[PATCH 10/13] target/i386: optimize CX handling in repeated string operations |
Date: |
Sun, 15 Dec 2024 10:06:09 +0100 |
In a repeated string operation, CX/ECX will be decremented until it
is 0 but never underflow. Use this observation to avoid a deposit or
zero-extend operation if the address size of the operation is smaller
than MO_TL.
As in the previous patch, the patch is structured to include some
preparatory work for subsequent changes. In particular, introducing
cx_next prepares for when ECX will be decremented *before* calling
fn(s, ot), and therefore cannot yet be written back to cpu_regs.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/tcg/translate.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 8ef938372d5..2ea8a418612 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -1337,6 +1337,7 @@ static void do_gen_rep(DisasContext *s, MemOp ot,
{
TCGLabel *done = gen_new_label();
target_ulong cx_mask = MAKE_64BIT_MASK(0, 8 << s->aflag);
+ TCGv cx_next = tcg_temp_new();
bool had_rf = s->flags & HF_RF_MASK;
/*
@@ -1362,7 +1363,19 @@ static void do_gen_rep(DisasContext *s, MemOp ot,
tcg_gen_brcondi_tl(TCG_COND_TSTEQ, cpu_regs[R_ECX], cx_mask, done);
fn(s, ot);
- gen_op_add_reg_im(s, s->aflag, R_ECX, -1);
+
+ tcg_gen_subi_tl(cx_next, cpu_regs[R_ECX], 1);
+
+ /*
+ * Write back cx_next to CX/ECX/RCX. There can be no carry, so zero
+ * extend if needed but do not do expensive deposit operations.
+ */
+#ifdef TARGET_X86_64
+ if (s->aflag == MO_32) {
+ tcg_gen_ext32u_tl(cx_next, cx_next);
+ }
+#endif
+ tcg_gen_mov_tl(cpu_regs[R_ECX], cx_next);
gen_update_cc_op(s);
/* Leave if REP condition fails. */
--
2.47.1
- Re: [PATCH 07/13] target/i386: fix RF handling for string instructions, (continued)
- [PATCH 06/13] target/i386: tcg: move gen_set/reset_* earlier in the file, Paolo Bonzini, 2024/12/15
- [PATCH 08/13] target/i386: make cc_op handling more explicit for repeated string instructions., Paolo Bonzini, 2024/12/15
- [PATCH 09/13] target/i386: do not use gen_op_jz_ecx for repeated string operations, Paolo Bonzini, 2024/12/15
- [PATCH 10/13] target/i386: optimize CX handling in repeated string operations,
Paolo Bonzini <=
- [PATCH 11/13] target/i386: execute multiple REP/REPZ iterations without leaving TB, Paolo Bonzini, 2024/12/15
- [PATCH 12/13] target/i386: pull computation of string update value out of loop, Paolo Bonzini, 2024/12/15
- [PATCH 13/13] target/i386: avoid using s->tmp0 for add to implicit registers, Paolo Bonzini, 2024/12/15